Add Slack DM recipient picker (user-message mount model)#156
Merged
Conversation
Make 1:1 Slack DMs a first-class, selectable Pear source using the canonical user-recipient model `/slack/users/<U>/messages` (bare Slack user ids). This is the Pear/UI-mount layer of the comprehensive DM build; it pairs with the relayfile adapter D→U materialization and Cloud token/options wiring. - New `SlackDmRecipientPicker` (reuses `GenericScopePicker`): consumes Cloud `users` options and emits concrete `/slack/users/<U>/messages` mount paths. - `GenericScopePicker` gains `defaultSelectAll` (default true; preserves channel behavior). DM picker sets it false so a fresh picker mounts NO one's DMs by default — readability requires explicitly selecting recipients. - `ProjectSettings`: separate channel vs DM pending scope state, merged into one `mountPaths` via `mergeSlackScopeMountPaths` (each half preserved when the other changes; discovery paths kept). `listenDms` stays watch-only with copy clarifying it observes events; recipients must be chosen to read/send DMs. - Demote the vestigial `/slack/dms/*` event watch glob — no adapter resource or record ever materialized there. Canonical DM watch is `/slack/users/*/messages/**`; `/slack/channels/D*` stays diagnostic-only. - Bare `U…`/`W…` ids only; never suffixed `U…__slug` (adapter writeback and Cloud scope aliasing only bridge channel suffixes today). Tests: `slack-scope.test.ts` (helpers + mount-path merge) and an `integration-event-bridge` glob test asserting the user-message watch is canonical and `/slack/dms/*` is dropped. Source-only; no rebuild of the running instance. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
📝 WalkthroughWalkthroughAdds Slack DM recipient selection: backend simplifies DM glob config and exports the glob builder; frontend adds Slack mount-path utilities and tests, makes GenericScopePicker opt-out-capable, creates SlackDmRecipientPicker, and integrates DM selection into ProjectSettings. ChangesSlack Direct Message Recipient Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for selecting specific Slack DM recipients to read and send direct messages, replacing the vestigial /slack/dms paths. It adds a new SlackDmRecipientPicker component, updates ProjectSettings to manage DM scope state, and introduces robust helper functions and unit tests in slack-scope.ts to merge channel and DM-recipient mount paths. The reviewer's feedback focuses on improving robustness by adding defensive checks and nullish guards across several new helper functions and components to prevent potential runtime TypeError crashes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+60
to
+66
| export function isSlackChannelMountPath(path: string): boolean { | ||
| return /^\/slack\/channels(?:\/|$)/u.test(path.trim()) | ||
| } | ||
|
|
||
| export function isSlackUserMessagesMountPath(path: string): boolean { | ||
| return /^\/slack\/users\/[^/]+\/messages(?:\/|$)/u.test(path.trim()) | ||
| } |
There was a problem hiding this comment.
The isSlackChannelMountPath and isSlackUserMessagesMountPath functions assume path is always a string and call path.trim(). If path is null, undefined, or of another type, this will throw a TypeError. Adding a typeof path === 'string' check prevents runtime crashes when filtering lists of mount paths that might contain nullish or malformed entries.
Suggested change
| export function isSlackChannelMountPath(path: string): boolean { | |
| return /^\/slack\/channels(?:\/|$)/u.test(path.trim()) | |
| } | |
| export function isSlackUserMessagesMountPath(path: string): boolean { | |
| return /^\/slack\/users\/[^/]+\/messages(?:\/|$)/u.test(path.trim()) | |
| } | |
| export function isSlackChannelMountPath(path: string): boolean { | |
| return typeof path === 'string' && /^\/slack\/channels(?:\/|$)/u.test(path.trim()) | |
| } | |
| export function isSlackUserMessagesMountPath(path: string): boolean { | |
| return typeof path === 'string' && /^\/slack\/users\/[^/]+\/messages(?:\/|$)/u.test(path.trim()) | |
| } |
Comment on lines
+12
to
+26
| function resourceField(resource: IntegrationAccessibleResource, ...keys: Array<keyof IntegrationAccessibleResource>): string { | ||
| for (const key of keys) { | ||
| const value = resource[key] | ||
| if (typeof value === 'string' && value.trim()) return value.trim() | ||
| } | ||
| return '' | ||
| } | ||
|
|
||
| function resourceMeta(resource: IntegrationAccessibleResource, ...keys: string[]): string { | ||
| for (const key of keys) { | ||
| const value = resource.metadata?.[key] | ||
| if (typeof value === 'string' && value.trim()) return value.trim() | ||
| } | ||
| return '' | ||
| } |
There was a problem hiding this comment.
The resourceField and resourceMeta helper functions do not guard against a null or undefined resource object. If resource is nullish at runtime, accessing properties like resource[key] or resource.metadata will throw a TypeError. Adding a simple nullish guard at the beginning of these functions ensures robustness.
function resourceField(resource: IntegrationAccessibleResource | null | undefined, ...keys: Array<keyof IntegrationAccessibleResource>): string {
if (!resource) return ''
for (const key of keys) {
const value = resource[key]
if (typeof value === 'string' && value.trim()) return value.trim()
}
return ''
}
function resourceMeta(resource: IntegrationAccessibleResource | null | undefined, ...keys: string[]): string {
if (!resource) return ''
for (const key of keys) {
const value = resource.metadata?.[key]
if (typeof value === 'string' && value.trim()) return value.trim()
}
return ''
}
Comment on lines
+30
to
+39
| export function slackDmUserId(resource: IntegrationAccessibleResource): string { | ||
| return resourceMeta(resource, 'userId') || resourceField(resource, 'id', 'slug', 'key', 'name') | ||
| } | ||
|
|
||
| /** Mount segment appended to `/slack/users` → `<U…>/messages`, yielding the | ||
| * canonical 1:1 DM path `/slack/users/<U…>/messages`. Empty when no id. */ | ||
| export function slackDmMountSegment(resource: IntegrationAccessibleResource): string { | ||
| const id = slackDmUserId(resource) | ||
| return id ? `${id}/messages` : '' | ||
| } |
There was a problem hiding this comment.
Update the signatures of slackDmUserId and slackDmMountSegment to accept IntegrationAccessibleResource | null | undefined to align with the defensive guards added to resourceField and resourceMeta.
Suggested change
| export function slackDmUserId(resource: IntegrationAccessibleResource): string { | |
| return resourceMeta(resource, 'userId') || resourceField(resource, 'id', 'slug', 'key', 'name') | |
| } | |
| /** Mount segment appended to `/slack/users` → `<U…>/messages`, yielding the | |
| * canonical 1:1 DM path `/slack/users/<U…>/messages`. Empty when no id. */ | |
| export function slackDmMountSegment(resource: IntegrationAccessibleResource): string { | |
| const id = slackDmUserId(resource) | |
| return id ? `${id}/messages` : '' | |
| } | |
| export function slackDmUserId(resource: IntegrationAccessibleResource | null | undefined): string { | |
| return resourceMeta(resource, 'userId') || resourceField(resource, 'id', 'slug', 'key', 'name') | |
| } | |
| /** Mount segment appended to `/slack/users` → `<U…>/messages`, yielding the | |
| * canonical 1:1 DM path `/slack/users/<U…>/messages`. Empty when no id. */ | |
| export function slackDmMountSegment(resource: IntegrationAccessibleResource | null | undefined): string { | |
| const id = slackDmUserId(resource) | |
| return id ? `${id}/messages` : '' | |
| } |
Comment on lines
+42
to
+58
| export function slackUserResourceFromOption(option: { | ||
| value: string | ||
| label: string | ||
| hint?: string | ||
| }): IntegrationAccessibleResource { | ||
| const id = option.value.trim() | ||
| const name = option.label.replace(/^@/u, '').trim() || id | ||
| return { | ||
| id, | ||
| displayName: option.label, | ||
| name, | ||
| metadata: { | ||
| userId: id, | ||
| ...(option.hint ? { hint: option.hint } : {}) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The slackUserResourceFromOption function does not guard against a null or undefined option or missing string properties. If option or option.value is nullish, calling .trim() will throw a TypeError. Adding optional chaining and fallback values makes this mapper function much more resilient to malformed API responses.
Suggested change
| export function slackUserResourceFromOption(option: { | |
| value: string | |
| label: string | |
| hint?: string | |
| }): IntegrationAccessibleResource { | |
| const id = option.value.trim() | |
| const name = option.label.replace(/^@/u, '').trim() || id | |
| return { | |
| id, | |
| displayName: option.label, | |
| name, | |
| metadata: { | |
| userId: id, | |
| ...(option.hint ? { hint: option.hint } : {}) | |
| } | |
| } | |
| } | |
| export function slackUserResourceFromOption(option: { | |
| value: string | |
| label: string | |
| hint?: string | |
| }): IntegrationAccessibleResource { | |
| const id = (option?.value || '').trim() | |
| const label = option?.label || '' | |
| const name = label.replace(/^@/u, '').trim() || id | |
| return { | |
| id, | |
| displayName: label, | |
| name, | |
| metadata: { | |
| userId: id, | |
| ...(option?.hint ? { hint: option.hint } : {}) | |
| } | |
| } | |
| } |
Comment on lines
+644
to
+656
| const listSlackDmRecipients = useCallback(async (integration: ConnectedIntegration): Promise<IntegrationAccessibleResource[]> => { | ||
| const cacheKey = `slack-users:${projectId}:${integration.integrationId}` | ||
| return cachedResources(cacheKey, async () => { | ||
| const listOptions = (pear.integrations as typeof pear.integrations & { | ||
| listOptions?: typeof pear.integrations.listOptions | ||
| }).listOptions | ||
| if (typeof listOptions !== 'function') { | ||
| throw new Error('Slack DM recipient options are not available yet.') | ||
| } | ||
| const options = await listOptions(projectId, integration.provider, 'users') | ||
| return options.map(slackUserResourceFromOption) | ||
| }) | ||
| }, [cachedResources, projectId]) |
There was a problem hiding this comment.
If listOptions returns a non-array value (e.g., due to an unexpected API response or error state), calling options.map will throw a TypeError. Adding an Array.isArray(options) check ensures the application handles unexpected API payloads gracefully.
Suggested change
| const listSlackDmRecipients = useCallback(async (integration: ConnectedIntegration): Promise<IntegrationAccessibleResource[]> => { | |
| const cacheKey = `slack-users:${projectId}:${integration.integrationId}` | |
| return cachedResources(cacheKey, async () => { | |
| const listOptions = (pear.integrations as typeof pear.integrations & { | |
| listOptions?: typeof pear.integrations.listOptions | |
| }).listOptions | |
| if (typeof listOptions !== 'function') { | |
| throw new Error('Slack DM recipient options are not available yet.') | |
| } | |
| const options = await listOptions(projectId, integration.provider, 'users') | |
| return options.map(slackUserResourceFromOption) | |
| }) | |
| }, [cachedResources, projectId]) | |
| const listSlackDmRecipients = useCallback(async (integration: ConnectedIntegration): Promise<IntegrationAccessibleResource[]> => { | |
| const cacheKey = 'slack-users:' + projectId + ':' + integration.integrationId | |
| return cachedResources(cacheKey, async () => { | |
| const listOptions = (pear.integrations as typeof pear.integrations & { | |
| listOptions?: typeof pear.integrations.listOptions | |
| }).listOptions | |
| if (typeof listOptions !== 'function') { | |
| throw new Error('Slack DM recipient options are not available yet.') | |
| } | |
| const options = await listOptions(projectId, integration.provider, 'users') | |
| return Array.isArray(options) ? options.map(slackUserResourceFromOption) : [] | |
| }) | |
| }, [cachedResources, projectId]) |
Comment on lines
+674
to
+676
| dmPaths: pendingDmScopeValue | ||
| ? pendingDmScopeValue.mountPaths.filter(isSlackUserMessagesMountPath) | ||
| : null |
There was a problem hiding this comment.
Guard against cases where pendingDmScopeValue is defined but mountPaths is missing or nullish at runtime, preventing potential TypeError crashes when calling .filter.
Suggested change
| dmPaths: pendingDmScopeValue | |
| ? pendingDmScopeValue.mountPaths.filter(isSlackUserMessagesMountPath) | |
| : null | |
| dmPaths: pendingDmScopeValue?.mountPaths | |
| ? pendingDmScopeValue.mountPaths.filter(isSlackUserMessagesMountPath) | |
| : null |
Comment on lines
+768
to
+774
| const selectedSlackDmRecipientIds = Array.from(new Set([ | ||
| ...integration.mountPaths | ||
| .filter(isSlackUserMessagesMountPath) | ||
| .map((path) => path.split('/')[3]) | ||
| .filter(Boolean), | ||
| ...scopeStringList(integration.scope, 'dmUsers') | ||
| ])) |
There was a problem hiding this comment.
If integration.mountPaths is nullish or undefined at runtime, calling .filter on it will throw a TypeError. Adding a fallback empty array (integration.mountPaths || []) ensures the component renders safely.
Suggested change
| const selectedSlackDmRecipientIds = Array.from(new Set([ | |
| ...integration.mountPaths | |
| .filter(isSlackUserMessagesMountPath) | |
| .map((path) => path.split('/')[3]) | |
| .filter(Boolean), | |
| ...scopeStringList(integration.scope, 'dmUsers') | |
| ])) | |
| const selectedSlackDmRecipientIds = Array.from(new Set([ | |
| ...(integration.mountPaths || []) | |
| .filter(isSlackUserMessagesMountPath) | |
| .map((path) => path.split('/')[3]) | |
| .filter(Boolean), | |
| ...scopeStringList(integration.scope, 'dmUsers') | |
| ])) |
The scope-editor open/close toggle reset pendingScopeValue + pendingSlackListenDms but not the new pendingDmScopeValue, so an unsaved DM-recipient selection could survive closing the editor and be applied on a later Save for the same or another Slack integration. Clear it in the toggle handler alongside the other pending state (Cancel and save-success paths already cleared it). Reported by event-path-codex on PR #156. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
Contributor
|
✅ pr-reviewer applied fixes — committed and pushed Implemented the validated PR fixes for Slack DM scoping robustness. Changes made:
Verification run:
GitHub status check: current PR metadata reports Addressed comments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/renderer/src/components/settings/ProjectSettings.tsx">
<violation number="1" location="src/renderer/src/components/settings/ProjectSettings.tsx:654">
P2: Malformed DM options responses are silently swallowed as an empty list, hiding integration/API failures from users.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/renderer/src/components/settings/ProjectSettings.tsx">
<violation number="1" location="src/renderer/src/components/settings/ProjectSettings.tsx:666">
P2: DM recipient state can be unintentionally cleared when recipient options are empty/unavailable, because pending picker output overwrites existing `dmUsers`/DM mount paths.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| selection: pendingScopeValue?.scope.selection ?? integration.scope.selection ?? 'selected', | ||
| channels: pendingScopeValue?.scope.channels ?? integration.scope.channels ?? [], | ||
| resources: pendingScopeValue?.scope.resources ?? integration.scope.resources ?? [], | ||
| dmUsers: pendingDmScopeValue?.scope.dmUsers ?? integration.scope.dmUsers ?? [], |
There was a problem hiding this comment.
P2: DM recipient state can be unintentionally cleared when recipient options are empty/unavailable, because pending picker output overwrites existing dmUsers/DM mount paths.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/renderer/src/components/settings/ProjectSettings.tsx, line 666:
<comment>DM recipient state can be unintentionally cleared when recipient options are empty/unavailable, because pending picker output overwrites existing `dmUsers`/DM mount paths.</comment>
<file context>
@@ -642,8 +663,18 @@ function IntegrationVisibilitySection({
selection: pendingScopeValue?.scope.selection ?? integration.scope.selection ?? 'selected',
channels: pendingScopeValue?.scope.channels ?? integration.scope.channels ?? [],
resources: pendingScopeValue?.scope.resources ?? integration.scope.resources ?? [],
+ dmUsers: pendingDmScopeValue?.scope.dmUsers ?? integration.scope.dmUsers ?? [],
listenDms
}
</file context>
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
Contributor
|
Implemented fixes for the valid current findings:
Local validation passed:
Remote PR metadata currently reports the PR as mergeable and GitHub Actions jobs complete/successful, but the Cubic AI check was still Addressed comments
|
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/renderer/src/components/settings/ProjectSettings.tsx`:
- Around line 767-771: The code adds all integration.mountPaths into
selectedSlackSourceIds, which incorrectly includes DM mounts like
"/slack/users/<U>/messages"; update the logic that builds integrationMountPaths
(and thus selectedSlackSourceIds) to filter out DM-style mount paths before
creating the Set. Specifically, transform integration.mountPaths (used in the
integrationMountPaths variable) by excluding entries that match Slack DM
patterns (e.g. paths starting with "/slack/users/") so that only
channel/conversation mount paths are merged with
scopeStringList(integration.scope, 'channels') for
GenericScopePicker/SlackChannelPicker initial state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0c290339-a336-4cc1-9407-010ca09110a0
📒 Files selected for processing (6)
src/main/__tests__/integration-event-bridge.test.tssrc/main/integration-event-bridge.tssrc/renderer/src/components/settings/ProjectSettings.tsxsrc/renderer/src/components/settings/scope-pickers/GenericScopePicker.tsxsrc/renderer/src/components/settings/slack-scope.test.tssrc/renderer/src/components/settings/slack-scope.ts
🚧 Files skipped from review as they are similar to previous changes (5)
- src/main/tests/integration-event-bridge.test.ts
- src/renderer/src/components/settings/slack-scope.test.ts
- src/main/integration-event-bridge.ts
- src/renderer/src/components/settings/scope-pickers/GenericScopePicker.tsx
- src/renderer/src/components/settings/slack-scope.ts
Comment on lines
+767
to
771
| const integrationMountPaths = integration.mountPaths ?? [] | ||
| const selectedSlackSourceIds = Array.from(new Set([ | ||
| ...integration.mountPaths, | ||
| ...integrationMountPaths, | ||
| ...scopeStringList(integration.scope, 'channels') | ||
| ])) |
There was a problem hiding this comment.
Filter DM mount paths out of the channel picker seed state.
Lines 767-771 now feed every integration.mountPaths entry into selectedSlackSourceIds. After this PR, that includes DM mounts like /slack/users/<U>/messages, so a DM-only Slack integration no longer looks like “no prior channel selection” to GenericScopePicker. That changes the initial state of SlackChannelPicker and can turn a DM-only config into an apparent empty channel selection on the next save.
Suggested fix
const slackListenDms = pendingSlackListenDms ?? savedSlackListenDms
const integrationMountPaths = integration.mountPaths ?? []
+ const selectedSlackChannelMountPaths = integrationMountPaths.filter((path) =>
+ path.startsWith('/slack/channels/')
+ )
const selectedSlackSourceIds = Array.from(new Set([
- ...integrationMountPaths,
+ ...selectedSlackChannelMountPaths,
...scopeStringList(integration.scope, 'channels')
]))
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const integrationMountPaths = integration.mountPaths ?? [] | |
| const selectedSlackSourceIds = Array.from(new Set([ | |
| ...integration.mountPaths, | |
| ...integrationMountPaths, | |
| ...scopeStringList(integration.scope, 'channels') | |
| ])) | |
| const integrationMountPaths = integration.mountPaths ?? [] | |
| const selectedSlackChannelMountPaths = integrationMountPaths.filter((path) => | |
| path.startsWith('/slack/channels/') | |
| ) | |
| const selectedSlackSourceIds = Array.from(new Set([ | |
| ...selectedSlackChannelMountPaths, | |
| ...scopeStringList(integration.scope, 'channels') | |
| ])) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/renderer/src/components/settings/ProjectSettings.tsx` around lines 767 -
771, The code adds all integration.mountPaths into selectedSlackSourceIds, which
incorrectly includes DM mounts like "/slack/users/<U>/messages"; update the
logic that builds integrationMountPaths (and thus selectedSlackSourceIds) to
filter out DM-style mount paths before creating the Set. Specifically, transform
integration.mountPaths (used in the integrationMountPaths variable) by excluding
entries that match Slack DM patterns (e.g. paths starting with "/slack/users/")
so that only channel/conversation mount paths are merged with
scopeStringList(integration.scope, 'channels') for
GenericScopePicker/SlackChannelPicker initial state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pear/UI-mount layer of the comprehensive Slack DM build. Makes 1:1 DMs a first-class, selectable source via the canonical user-recipient model
/slack/users/<U>/messages(bare Slack user ids). Pairs with the relayfile adapter D→U materialization and the Cloud token/options wiring (separate PRs).What changed
SlackDmRecipientPicker(reusesGenericScopePicker): consumes Cloudusersoptions, emits concrete/slack/users/<U>/messagesmount paths.GenericScopePickergainsdefaultSelectAll(defaulttrue, preserves channel/GitHub/Linear/Notion behavior). The DM picker sets itfalseso a fresh picker mounts no one's DMs by default — readability requires explicitly choosing recipients (privacy + scale).ProjectSettings: separate channel vs DM pending scope state, merged into a singlemountPathsarray viamergeSlackScopeMountPaths(each half is preserved when only the other changes;/discovery/slackand other paths kept).listenDmsstays watch-only, with copy clarifying it only observes events — recipients must be selected to read/send DMs./slack/dms/*event watch glob — no adapter resource or record ever materialized there. Canonical DM watch is now/slack/users/*/messages/**;/slack/channels/D*is retained as diagnostic-only.U…/W…ids only — never suffixedU…__slug(adapter writeback extraction + CloudscopeMatchesPathonly bridge channel suffixes today).Tests
src/renderer/src/components/settings/slack-scope.test.ts— DM id/path helpers, mount-path classifiers, andmergeSlackScopeMountPaths(select adds + preserves channels/discovery; channel change preserves DMs; clear drops DM mounts;listenDms-only invents nothing; dedupe/order). vitest 10/10.src/main/__tests__/integration-event-bridge.test.ts— assertslistenDmswatch globs include/slack/users/*/messages/**+/slack/channels/D*/**and exclude/slack/dms/*/**; none whenlistenDmsis off. node --test 63/63.Validation
npx vitest run …/slack-scope.test.ts→ 10/10node --experimental-strip-types --test …/integration-event-bridge.test.ts→ 63/63tsc -p tsconfig.web.json(build-matching es2022 flags) → no errors in changed filesNotes
ProjectSidebar.tsx,.claude/skills/,__.mcp.json,prpm.lock).🤖 Generated with Claude Code